Work with pools that don't support prepared statements #1147
Conversation
Introduce a new `query_with_param_types` method that allows to specify Postgres type parameters. This obviated the need to use prepared statementsjust to obtain parameter types for a query. It then combines parse, bind, and execute in a single packet. Related: sfackler#1017, sfackler#1067
| ) -> impl ExactSizeIterator<Item = (&'a dyn ToSql, Type)> + 'a { | ||
| s.iter() | ||
| .map(|(param, param_type)| (*param as _, param_type.clone())) | ||
| } |
There was a problem hiding this comment.
There's no need to factor this into a separate function here since it's only being called one place.
There was a problem hiding this comment.
Fixed. Earlier thought was to allow access to the raw RowStream.
tokio-postgres/src/query.rs
Outdated
| responses, | ||
| rows_affected: None, | ||
| _p: PhantomPinned, | ||
| }) | ||
| } | ||
|
|
||
| enum QueryProcessingState { |
There was a problem hiding this comment.
It feels like this is a lot of boilerplate over a few match responses.next().await? { ... } in a sequence.
|
Thinking about it, it seems like we could make query_typed do this when invoked with a non-prepared statement instead of adding a new method. |
Did you mean |
Ah yeah my idea didn't really make much sense :D |
|
Let's rename the method to |
Done! |
|
LGTM but there's one small clippy error to fix. |
Fixed. |
|
Thanks! |
Thank you! |
With sfackler/rust-postgres#1165 merged and a new release with that change available in 0.7.12, we no longer need to use our fork. Compared to sfackler/rust-postgres#1147, there was a name change for `query_typed`, so this commit takes care of that.
Introduce a new
query_with_param_typesmethod that allows to specify Postgres type parameters. This obviated the need to use prepared statements just to obtain parameter types for a query. It then combines parse, bind, and execute in a single packet.Related: #1017, #1067